Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Partially revert #1758 #1837

Merged
merged 5 commits into from
Jun 19, 2019
Merged

BUG: Partially revert #1758 #1837

merged 5 commits into from
Jun 19, 2019

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 17, 2019

This caused a few failures with downstream code, so I've reverted the changes
to ibis/pandas/core.py.

I've left other fixes from #1758 unchanged.

I'll revisit the reimplementation in the near future.

@pep8speaks
Copy link

pep8speaks commented Jun 17, 2019 •
edited
Loading

Hello @cpcloud! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-18 14:18:33 UTC

@cpcloud cpcloud added this to the Next Feature Release milestone Jun 17, 2019
@cpcloud cpcloud added bug Incorrect behavior inside of ibis pandas The pandas backend labels Jun 17, 2019
@cpcloud cpcloud self-assigned this Jun 17, 2019
@cpcloud cpcloud merged commit 730df43 into ibis-project:master Jun 19, 2019
@cpcloud cpcloud deleted the revert-topo branch June 19, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpcloud cpcloud

Labels
bug Incorrect behavior inside of ibis pandas The pandas backend
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @pep8speaks