Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Partially revert #1758 #1837

Merged
merged 5 commits into from Jun 19, 2019

Conversation

Projects
2 participants
@cpcloud
Copy link
Member

commented Jun 17, 2019

This caused a few failures with downstream code, so I've reverted the changes
to ibis/pandas/core.py.

I've left other fixes from #1758 unchanged.

I'll revisit the reimplementation in the near future.

cpcloud added some commits Jun 17, 2019

@pep8speaks

This comment has been minimized.

Copy link

commented Jun 17, 2019

Hello @cpcloud! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-18 14:18:33 UTC

@cpcloud cpcloud added this to the Next Feature Release milestone Jun 17, 2019

@cpcloud cpcloud added this to To do in Pandas via automation Jun 17, 2019

@cpcloud cpcloud self-assigned this Jun 17, 2019

@cpcloud cpcloud merged commit 730df43 into ibis-project:master Jun 19, 2019

13 checks passed

ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
ibis-project.ibis Build #20190618.2 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

Pandas automation moved this from To do to Done Jun 19, 2019

@cpcloud cpcloud deleted the cpcloud:revert-topo branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.