Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Allow pandas timedelta in rows_with_max_lookback #1838

Merged
merged 2 commits into from Jun 19, 2019

Conversation

Projects
None yet
2 participants
@emilyreff7
Copy link
Contributor

commented Jun 18, 2019

See issue: #1832

@cpcloud

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

@emilyreff7 You can actually close and issue on PR merge if you write "Closes #issue". Here's some docs on that feature of GitHub: https://help.github.com/en/articles/closing-issues-using-keywords

@cpcloud cpcloud added this to the 1.2.0 milestone Jun 18, 2019

@cpcloud cpcloud self-requested a review Jun 18, 2019

@cpcloud
Copy link
Member

left a comment

Minor comment, otherwise LGTM.

Show resolved Hide resolved ibis/expr/window.py Outdated

@cpcloud cpcloud added the usability label Jun 18, 2019

@cpcloud cpcloud merged commit 5423109 into ibis-project:master Jun 19, 2019

13 checks passed

ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
ibis-project.ibis Build #20190618.4 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

@cpcloud cpcloud changed the title allow pandas timedelta in rows_with_max_lookback FEAT: Allow pandas timedelta in rows_with_max_lookback Jun 19, 2019

@emilyreff7 emilyreff7 deleted the emilyreff7:timedelta branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.