Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Allow pandas timedelta in rows_with_max_lookback #1838

Merged
merged 2 commits into from
Jun 19, 2019
Merged

FEAT: Allow pandas timedelta in rows_with_max_lookback #1838

merged 2 commits into from
Jun 19, 2019

Conversation

emilyreff7
Copy link
Contributor

@emilyreff7 emilyreff7 commented Jun 18, 2019 •
edited
Loading

See issue: #1832

@cpcloud
Copy link
Member

cpcloud commented Jun 18, 2019 •
edited
Loading

@emilyreff7 You can actually close and issue on PR merge if you write "Closes #issue". Here's some docs on that feature of GitHub: https://help.github.com/en/articles/closing-issues-using-keywords

@cpcloud cpcloud added this to the 1.2.0 milestone Jun 18, 2019
@cpcloud cpcloud self-requested a review June 18, 2019 16:05
cpcloud
cpcloud requested changes Jun 18, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise LGTM.

ibis/expr/window.py Outdated Show resolved Hide resolved
@cpcloud cpcloud added the ux User experience related issues label Jun 18, 2019
@cpcloud cpcloud merged commit 5423109 into ibis-project:master Jun 19, 2019
@cpcloud cpcloud changed the title allow pandas timedelta in rows_with_max_lookback FEAT: Allow pandas timedelta in rows_with_max_lookback Jun 19, 2019
@emilyreff7 emilyreff7 deleted the timedelta branch June 19, 2019 13:39
@cpcloud cpcloud mentioned this pull request Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
ux User experience related issues
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@emilyreff7 @cpcloud