Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Add max_lookback to window replace and combine functions #1843

Merged
merged 5 commits into from Jun 19, 2019

Conversation

Projects
None yet
2 participants
@emilyreff7
Copy link
Contributor

commented Jun 19, 2019

Closes #1842

@cpcloud cpcloud added this to the 1.2.0 milestone Jun 19, 2019

@cpcloud
Copy link
Member

left a comment

Just needs a test for _replace then this is good to go.

Show resolved Hide resolved ibis/expr/window.py

@cpcloud cpcloud merged commit 45bc01d into ibis-project:master Jun 19, 2019

13 checks passed

ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
ibis-project.ibis Build #20190619.6 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

@emilyreff7 emilyreff7 deleted the emilyreff7:maxrows-fix branch Jun 19, 2019

@cpcloud cpcloud added the bug label Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.