Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Add max_lookback to window replace and combine functions #1843

Merged
merged 5 commits into from
Jun 19, 2019
Merged

BUG: Add max_lookback to window replace and combine functions #1843

merged 5 commits into from
Jun 19, 2019

Conversation

emilyreff7
Copy link
Contributor

Closes #1842

@cpcloud cpcloud added this to the 1.2.0 milestone Jun 19, 2019
cpcloud
cpcloud requested changes Jun 19, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a test for _replace then this is good to go.

ibis/expr/window.py Show resolved Hide resolved
@cpcloud cpcloud added ux User experience related issues window functions Issues or PRs related to window functions labels Jun 19, 2019
@cpcloud cpcloud merged commit 45bc01d into ibis-project:master Jun 19, 2019
@emilyreff7 emilyreff7 deleted the maxrows-fix branch June 19, 2019 20:37
@cpcloud cpcloud added the bug Incorrect behavior inside of ibis label Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis ux User experience related issues window functions Issues or PRs related to window functions
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

BUG: Add max_lookback to window replace and combine functions
2 participants
@emilyreff7 @cpcloud