Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPP: Raise exception on backends where rows_with_max_lookback can't be implemented #1844

Merged
merged 9 commits into from
Jun 20, 2019
Merged

SUPP: Raise exception on backends where rows_with_max_lookback can't be implemented #1844

merged 9 commits into from
Jun 20, 2019

Conversation

emilyreff7
Copy link
Contributor

Closes #1833

@cpcloud cpcloud added this to the 1.2.0 milestone Jun 20, 2019
@cpcloud cpcloud added feature Features or general enhancements ux User experience related issues and removed feature Features or general enhancements labels Jun 20, 2019
cpcloud
cpcloud requested changes Jun 20, 2019
View reviewed changes
ibis/impala/tests/test_window.py Show resolved Hide resolved
ibis/pandas/execution/tests/test_window.py Outdated Show resolved Hide resolved
ibis/pandas/execution/window.py Outdated Show resolved Hide resolved
ibis/sql/postgres/tests/test_functions.py Show resolved Hide resolved
ibis/impala/compiler.py Outdated Show resolved Hide resolved
ibis/sql/alchemy.py Outdated Show resolved Hide resolved
@cpcloud cpcloud merged commit 3a62abe into ibis-project:master Jun 20, 2019
@emilyreff7 emilyreff7 deleted the exceptions branch June 20, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
ux User experience related issues
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

SUPP: Raise exception on backends where rows_with_max_lookback can't be implemented
2 participants
@emilyreff7 @cpcloud