Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPP: Skip SQLAlchemy backend tests in connect method in backends.py #1847

Merged
merged 2 commits into from Jun 24, 2019

Conversation

Projects
None yet
1 participant
@cpcloud
Copy link
Member

commented Jun 20, 2019

Also did some refactoring of backends.py.

Closes #1846

@cpcloud cpcloud added this to the 1.2.0 milestone Jun 20, 2019

@cpcloud cpcloud force-pushed the cpcloud:sa-skip-backend-all-tests branch 2 times, most recently from eff68b4 to 3a5aa8e Jun 20, 2019

@cpcloud cpcloud force-pushed the cpcloud:sa-skip-backend-all-tests branch from 3a5aa8e to 64b6dca Jun 24, 2019

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

Merging on green

@cpcloud cpcloud merged commit f05fad2 into ibis-project:master Jun 24, 2019

13 checks passed

ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
ibis-project.ibis Build #20190624.5 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

@cpcloud cpcloud deleted the cpcloud:sa-skip-backend-all-tests branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.