Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPP: Validate order_by when using rows_with_max_lookback window #1848

Merged
merged 3 commits into from
Jun 20, 2019
Merged

SUPP: Validate order_by when using rows_with_max_lookback window #1848

merged 3 commits into from
Jun 20, 2019

Conversation

emilyreff7
Copy link
Contributor

Closes #1841

cpcloud
cpcloud reviewed Jun 20, 2019
View reviewed changes
ibis/expr/operations.py Outdated Show resolved Hide resolved
cpcloud
cpcloud reviewed Jun 20, 2019
View reviewed changes
ibis/expr/operations.py Outdated Show resolved Hide resolved
@cpcloud cpcloud added the feature Features or general enhancements label Jun 20, 2019
@cpcloud cpcloud added this to the 1.2.0 milestone Jun 20, 2019
cpcloud
cpcloud reviewed Jun 20, 2019
View reviewed changes
ibis/expr/operations.py Outdated Show resolved Hide resolved
cpcloud
cpcloud approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@cpcloud cpcloud merged commit 098a7ad into ibis-project:master Jun 20, 2019
@emilyreff7 emilyreff7 deleted the orderby branch June 25, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
feature Features or general enhancements
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

SUPP: Verify requirements for rows_with_max_lookback
2 participants
@emilyreff7 @cpcloud