Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPP: Validate order_by when using rows_with_max_lookback window #1848

Merged
merged 3 commits into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@emilyreff7
Copy link
Contributor

commented Jun 20, 2019

Closes #1841

Show resolved Hide resolved ibis/expr/operations.py Outdated
Show resolved Hide resolved ibis/expr/operations.py Outdated

@cpcloud cpcloud added the enhancement label Jun 20, 2019

@cpcloud cpcloud added this to the 1.2.0 milestone Jun 20, 2019

Show resolved Hide resolved ibis/expr/operations.py Outdated
@cpcloud
Copy link
Member

left a comment

LGTM, merging.

@cpcloud cpcloud merged commit 098a7ad into ibis-project:master Jun 20, 2019

6 of 13 checks passed

ci/circleci: python35_test Your tests are queued behind your running builds
Details
ci/circleci: python36_benchmark CircleCI is running your tests
Details
ci/circleci: python36_conda_build CircleCI is running your tests
Details
ci/circleci: python36_docs Your tests are queued behind your running builds
Details
ci/circleci: python36_test CircleCI is running your tests
Details
ci/circleci: python37_conda_build Your tests are queued behind your running builds
Details
ci/circleci: python37_test CircleCI is running your tests
Details
ibis-project.ibis Build #20190620.19 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

@emilyreff7 emilyreff7 deleted the emilyreff7:orderby branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.