Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Add shapely geometries as input for literals #1860

Merged
merged 3 commits into from
Aug 7, 2019
Merged

FEAT: Add shapely geometries as input for literals #1860

merged 3 commits into from
Aug 7, 2019

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Jun 27, 2019 •
edited
Loading

In this PR:

  • Add shapely geometries as input for literals
  • add tests for shapely geometries as input for literals

@xmnlab xmnlab marked this pull request as ready for review June 27, 2019 01:21
@xmnlab xmnlab requested a review from cpcloud June 27, 2019 01:21
@codecov
Copy link

codecov bot commented Jun 27, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5a72fbd). Click here to learn what that means.
The diff coverage is 83.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1860   +/-   ##
=========================================
  Coverage          ?   85.64%           
=========================================
  Files             ?       82           
  Lines             ?    15585           
  Branches          ?     2003           
=========================================
  Hits              ?    13347           
  Misses            ?     1865           
  Partials          ?      373
Impacted Files Coverage Δ
ibis/common/_exceptions.py 100% <ø> (ø)
ibis/impala/kudu_support.py 2.32% <0%> (ø)
ibis/expr/visualize.py 87.34% <100%> (ø)
ibis/pandas/execution/generic.py 85.03% <100%> (ø)
ibis/impala/pandas_interop.py 88% <100%> (ø)
ibis/sql/alchemy.py 92.33% <100%> (ø)
ibis/sql/sqlite/client.py 91.83% <100%> (ø)
ibis/sql/compiler.py 94.27% <100%> (ø)
ibis/bigquery/api.py 63.33% <100%> (ø)
ibis/impala/udf.py 38.51% <100%> (ø)
... and 32 more

This was referenced Jun 29, 2019
Merged
Merged
@cpcloud
Copy link
Member

cpcloud commented Jul 3, 2019

@xmnlab Looks like there are some merge conflicts.

@xmnlab
Copy link
Contributor Author

xmnlab commented Jul 3, 2019

@cpcloud you're right. I am working now on #1858 .. after that I will be back to this one.

@cpcloud
Copy link
Member

cpcloud commented Jul 25, 2019

@xmnlab Looks like you need to rebase and resolve the merge conflicts. That should also cut down on the number of files to review as well.

@xmnlab xmnlab force-pushed the add-shapely-input branch 2 times, most recently from 9576537 to d1c46d5 Compare August 2, 2019 20:16
@pep8speaks
Copy link

pep8speaks commented Aug 2, 2019 •
edited
Loading

Hello @xmnlab! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-08-07 02:15:48 UTC

@xmnlab
Copy link
Contributor Author

xmnlab commented Aug 3, 2019

from linux conda build:

==================================== ERRORS ====================================
________________________ ERROR collecting test session _________________________
E   KeyError: local('$SRC_DIR/ibis/sql/postgres/tests/conftest.py')

During handling of the above exception, another exception occurred:
E   ModuleNotFoundError: No module named 'shapely'

resolving this problem with conda-forge/ibis-framework-feedstock#36

cpcloud
cpcloud requested changes Aug 6, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, otherwise LGTM.

ci/impalamgr.py Outdated Show resolved Hide resolved
ibis/common/geospatial.py Outdated Show resolved Hide resolved
ibis/common/geospatial.py Outdated Show resolved Hide resolved
xmnlab
xmnlab commented Aug 6, 2019
View reviewed changes
Copy link
Contributor Author

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpcloud thanks for the review and feedback. I am working now to apply your suggestion.

@xmnlab xmnlab requested a review from cpcloud August 7, 2019 02:49
@xmnlab
Copy link
Contributor Author

xmnlab commented Aug 7, 2019

@cpcloud it is done again for a new review!

@dharhas dharhas mentioned this pull request Aug 7, 2019
Closed
2 tasks
cpcloud
cpcloud approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@cpcloud cpcloud self-assigned this Aug 7, 2019
@cpcloud cpcloud added this to the Next Feature Release milestone Aug 7, 2019
@cpcloud cpcloud added the postgis label Aug 7, 2019
@cpcloud cpcloud merged commit 8bb84bb into ibis-project:master Aug 7, 2019
@xmnlab xmnlab deleted the add-shapely-input branch August 7, 2019 19:39
cpcloud pushed a commit that referenced this pull request Aug 15, 2019
@xmnlab @cpcloud
SUPP: Rename mapd to omniscidb backend
9df2795 
depends on #1860    In this PR  - Rename mapd backend to omniscidb
Author: Ivan Ogasawara <ivan.ogasawara@gmail.com>

Closes #1866 from xmnlab/rename-mapd-to-omniscidb and squashes the following commits:

07923a0 [Ivan Ogasawara] Fixed old importing
0302721 [Ivan Ogasawara] Rename mapd to omniscidb
@cpcloud cpcloud modified the milestones: Next Feature Release, Next Major Release Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees

@cpcloud cpcloud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmnlab @cpcloud @pep8speaks