SUPP: Rename mapd to omniscidb backend #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmnlab
force-pushed
the
rename-mapd-to-omniscidb
branch
from
edbc95b
to
ea989bd
Compare
xmnlab
force-pushed
the
rename-mapd-to-omniscidb
branch
from
8dfa49a
to
2e72983
Compare
2 tasks
xmnlab
force-pushed
the
rename-mapd-to-omniscidb
branch
from
2e72983
to
7101d74
Compare
xmnlab
force-pushed
the
rename-mapd-to-omniscidb
branch
from
49ed665
to
2a378b2
Compare
|
cc @niviksha |
xmnlab
force-pushed
the
rename-mapd-to-omniscidb
branch
from
4e09079
to
6796436
Compare
|
@cpcloud it is done for a review :) thanks! |
xmnlab
force-pushed
the
rename-mapd-to-omniscidb
branch
from
6796436
to
0302721
Compare
|
conflicts fixed. it is ready again for review. |
|
@xmnlab I think that because this is a wholesale rename we should bump ibis to |
|
@cpcloud thanks for the review! yes, you're right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1860
In this PR