Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fixed issues with geo data #1872

Merged
merged 2 commits into from
Jul 3, 2019
Merged

BUG: Fixed issues with geo data #1872

merged 2 commits into from
Jul 3, 2019

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Jul 2, 2019 •
edited
Loading

In this PR:

  • Update OmniSci CI to v4.7.0
  • Fix polygon format on tests
  • Fix postgis data load to keep field called id

Depends on ibis-project/testing-data#2 (merged)

@cpcloud cpcloud added this to the Next Feature Release milestone Jul 2, 2019
@cpcloud cpcloud self-requested a review July 2, 2019 23:44
@xmnlab xmnlab marked this pull request as ready for review July 3, 2019 05:25
@xmnlab xmnlab changed the title Fixed issues with geo data BUG: Fixed issues with geo data Jul 3, 2019
@xmnlab
Copy link
Contributor Author

xmnlab commented Jul 3, 2019

hey @cpcloud it is done for review :) thanks!

@xmnlab xmnlab mentioned this pull request Jul 3, 2019
Merged
@cpcloud cpcloud mentioned this pull request Jul 3, 2019
Merged
cpcloud
cpcloud approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@cpcloud cpcloud merged commit d5b61dd into ibis-project:master Jul 3, 2019
@xmnlab xmnlab deleted the fix-geo-data-test branch August 1, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmnlab @cpcloud