Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix the case where we do not have an index when using preceding with intervals #1876

Merged
merged 1 commit into from
Jul 11, 2019
Merged

BUG: Fix the case where we do not have an index when using preceding with intervals #1876

merged 1 commit into from
Jul 11, 2019

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 10, 2019 •
edited
Loading

Small bug in the pandas backend when ordering by a particular key and not grouping.

@cpcloud cpcloud added this to the Next Feature Release milestone Jul 10, 2019
@cpcloud cpcloud added bug Incorrect behavior inside of ibis tests Issues or PRs related to tests labels Jul 10, 2019
@cpcloud cpcloud self-assigned this Jul 10, 2019
emilyreff7
emilyreff7 reviewed Jul 10, 2019
View reviewed changes
Copy link
Contributor

@emilyreff7 emilyreff7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just one question but LGTM otherwise.

@cpcloud cpcloud merged commit a0ef6ba into ibis-project:master Jul 11, 2019
@cpcloud cpcloud deleted the fix-window-group-order branch July 11, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyreff7 emilyreff7 emilyreff7 approved these changes

Assignees

@cpcloud cpcloud

Labels
bug Incorrect behavior inside of ibis tests Issues or PRs related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @emilyreff7