Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix various Spark backend issues #1888

Merged
merged 14 commits into from
Jul 25, 2019
Merged

BUG: Fix various Spark backend issues #1888

merged 14 commits into from
Jul 25, 2019

Conversation

amroid
Copy link
Contributor

@amroid amroid commented Jul 18, 2019

No description provided.

@cpcloud
Copy link
Member

cpcloud commented Jul 18, 2019

Can you add some tests to cover the additional APIs you've implemented?

@cpcloud cpcloud added this to the Next Feature Release milestone Jul 18, 2019
@cpcloud cpcloud added the spark label Jul 18, 2019
@cpcloud cpcloud changed the title Spark small fixes BUG: Fix various Spark backend issues Jul 24, 2019
amroid added 13 commits July 24, 2019 15:21
@amroid
Fix spark float and double literal formatting (replicates part of f02…
031da23 
…9584)
@amroid
Added compile and verify methods to spark api
ab0ca40
@amroid
Add to_sql method in Spark compiler so that ibis.spark.compile actual…
1c52748 
…ly works
@amroid
Add tests for float translation and functions compile and verify from…
dd511a7 
… spark api
@amroid
Add importorskip for pyspark for test_verify in test_api.py
00a5910
@amroid
Fix pandas test that started passing an xfailed test due to new panda…
e4204a2 
…s release
@amroid
Change global spark testing client fixture to not be a fixture, so im…
0742e22 
…portorskip does not skip all backends
@amroid
Refactor spark testing client code into new spark_testing_client.py f…
d624775 
…ile in ibis module
@amroid
Add pandas <0.25 to requirements
7c56c66
@amroid
Refactor spark testing client code into ibis/all/tests/conftest.py
9046f75
@amroid
Revert b15f13a because pandas version restriction <0.25 was added to …
1dc4b32 
…requirements
@amroid
Use importorskip in global spark client testing method in ibis/tests/…
cdb9947 
…all/conftest.py
@amroid
Remove pandas version constraints
87f12fe
cpcloud
cpcloud approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small changes needed, otherwise LGTM.

ibis/spark/tests/conftest.py Outdated Show resolved Hide resolved
ibis/spark/tests/test_api.py Outdated Show resolved Hide resolved
ibis/spark/tests/test_numeric.py Show resolved Hide resolved
ibis/tests/backends.py Outdated Show resolved Hide resolved
@cpcloud cpcloud self-requested a review July 24, 2019 19:25
cpcloud
cpcloud requested changes Jul 24, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to request changes!

@cpcloud cpcloud merged commit c3025ae into ibis-project:master Jul 25, 2019
@amroid amroid deleted the spark-small-fixes branch July 25, 2019 19:55
@cpcloud cpcloud modified the milestones: Next Feature Release, Next Major Release Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amroid @cpcloud