Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Make Nodes enforce the proper signature #1891

Merged
merged 6 commits into from
Jul 24, 2019

Conversation

amroid
Copy link
Contributor

@amroid amroid commented Jul 22, 2019

No description provided.

@cpcloud cpcloud added this to the Next Feature Release milestone Jul 23, 2019
@cpcloud cpcloud added the bug Incorrect behavior inside of ibis label Jul 23, 2019
@cpcloud cpcloud changed the title Node signature fix BUG: Make Nodes enforce the proper signature Jul 23, 2019
@cpcloud
Copy link
Member

cpcloud commented Jul 24, 2019

@amroid Can you remove the constraints on pandas here and then rebase on top of/merge in master to your branch?

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging on green, thanks @amroid!

@cpcloud cpcloud merged commit 10b93c8 into ibis-project:master Jul 24, 2019
@amroid amroid deleted the node-signature-fix branch July 25, 2019 15:25
@cpcloud cpcloud modified the milestones: Next Feature Release, Next Major Release Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants