Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Removing linting from windows #1896

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 25, 2019

This is a workaround for the somewhat mysterious flake8 failures on Windows
so that we can get green builds.

@cpcloud cpcloud added this to the Next Feature Release milestone Jul 25, 2019
@cpcloud cpcloud added the ci Continuous Integration issues or PRs label Jul 25, 2019
@cpcloud cpcloud merged commit 9f8e70f into ibis-project:master Jul 25, 2019
@cpcloud
Copy link
Member Author

cpcloud commented Jul 25, 2019

@scottcode Merged this in the meantime to get passing builds. I'm not entirely sure what's happening here, but I don't have a windows box to debug this at the moment.

@cpcloud cpcloud deleted the fix-lint-windows branch July 25, 2019 19:11
@scottcode
Copy link
Contributor

@cpcloud I think it's reasonable to drop flake8 from Window, because it still gets done in the Linux environments. It's not really our job to test flake8's interoperability, just want to make sure the build conforms to the style.

@cpcloud cpcloud modified the milestones: Next Feature Release, Next Major Release Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants