Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: DDL support for Spark backend #1908

Merged
merged 21 commits into from
Aug 14, 2019
Merged

ENH: DDL support for Spark backend #1908

merged 21 commits into from
Aug 14, 2019

Conversation

amroid
Copy link
Contributor

@amroid amroid commented Aug 2, 2019

No description provided.

cpcloud
cpcloud requested changes Aug 5, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of duplication here, I think we can use inheritance to our advantage which will make this easier to review and therefore quicker to get in.

ibis/spark/ddl.py Outdated Show resolved Hide resolved
ibis/spark/ddl.py Outdated Show resolved Hide resolved
cpcloud
cpcloud requested changes Aug 6, 2019
View reviewed changes
ibis/spark/ddl.py Outdated Show resolved Hide resolved
ibis/spark/ddl.py Show resolved Hide resolved
ibis/spark/ddl.py Outdated Show resolved Hide resolved
ibis/spark/ddl.py Outdated Show resolved Hide resolved
ibis/spark/ddl.py Outdated Show resolved Hide resolved
ibis/spark/tests/test_ddl_compilation.py Outdated Show resolved Hide resolved
ibis/spark/tests/test_ddl_compilation.py Outdated Show resolved Hide resolved
@amroid
Refactor create_table_or_temp_view_from_csv, schema_from_csv, exists_…
9b5c3b4 
…table in SparkClient, move ibis-spark type translation into separate file ibis/spark/datatypes.py
@cpcloud cpcloud added this to the Next Feature Release milestone Aug 7, 2019
@cpcloud cpcloud added the spark label Aug 7, 2019
@cpcloud cpcloud self-assigned this Aug 7, 2019
@cpcloud
Copy link
Member

cpcloud commented Aug 8, 2019

@amroid Looks like the CI is failing

cpcloud
cpcloud requested changes Aug 13, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • make schema_from_csv and create_table_or_temp_view_from_csv private (add a leading underscore to the method name)
  • add tests for those two methods

cpcloud
cpcloud approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @amroid.

@cpcloud cpcloud changed the title DDL support for Spark backend ENH: DDL support for Spark backend Aug 14, 2019
@cpcloud cpcloud merged commit e156a05 into ibis-project:master Aug 14, 2019
@amroid amroid deleted the spark-ddl branch August 15, 2019 14:36
@cpcloud cpcloud modified the milestones: Next Feature Release, Next Major Release Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees

@cpcloud cpcloud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amroid @cpcloud