Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix union implementation #1910

Merged
merged 2 commits into from
Aug 7, 2019
Merged

BUG: Fix union implementation #1910

merged 2 commits into from
Aug 7, 2019

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 5, 2019

Closes #1909

@cpcloud cpcloud added this to the Next Feature Release milestone Aug 7, 2019
@cpcloud cpcloud self-assigned this Aug 7, 2019
@cpcloud cpcloud added bug Incorrect behavior inside of ibis pandas The pandas backend labels Aug 7, 2019
@cpcloud
Copy link
Member Author

cpcloud commented Aug 7, 2019

@toryhaavik Can you give this a review when you get a chance?

@toryhaavik
Copy link
Contributor

LGTM

@cpcloud cpcloud merged commit e102572 into ibis-project:master Aug 7, 2019
@cpcloud cpcloud deleted the fix-pandas-union branch August 7, 2019 19:28
@cpcloud cpcloud modified the milestones: Next Feature Release, Next Major Release Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpcloud cpcloud

Labels
bug Incorrect behavior inside of ibis pandas The pandas backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Union is broken in pandas backend
2 participants
@cpcloud @toryhaavik