Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing null literal op #1917

Merged
merged 4 commits into from
Aug 14, 2019
Merged

Added missing null literal op #1917

merged 4 commits into from
Aug 14, 2019

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Aug 12, 2019

Fix #1915

@xmnlab
Copy link
Contributor Author

xmnlab commented Aug 12, 2019

it breaks in some cases that uses bool heavyai/heavydb#375
for now I am skipping some tests for OmniSciDB that break for this issue.

@xmnlab xmnlab requested a review from cpcloud August 12, 2019 23:46
@xmnlab
Copy link
Contributor Author

xmnlab commented Aug 12, 2019

@cpcloud it is done for review :) thanks!

@xmnlab
Copy link
Contributor Author

xmnlab commented Aug 14, 2019

@cpcloud it is done for a new review.

cpcloud
cpcloud approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xmnlab!

@cpcloud cpcloud merged commit 28caee6 into ibis-project:master Aug 14, 2019
@cpcloud cpcloud added this to the Next Feature Release milestone Aug 14, 2019
@cpcloud cpcloud assigned cpcloud and xmnlab and unassigned cpcloud Aug 14, 2019
@xmnlab xmnlab deleted the omniscidb-null-literal branch August 14, 2019 19:23
@cpcloud cpcloud modified the milestones: Next Feature Release, Next Major Release Aug 26, 2019
@anmyachev
Copy link
Contributor

@xmnlab in 'projects' tab the PR has status 'in progress' but should has 'done', shouldn't it?

@xmnlab
Copy link
Contributor Author

xmnlab commented Jan 27, 2020

thanks @anmyachev for catching that up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees

@xmnlab xmnlab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: OmniSciDB/MapD aggregate with where param doesn't work
3 participants
@xmnlab @anmyachev @cpcloud