Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fixes explain operation #1933

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Aug 20, 2019

In this PR:

  • Fixes explain operation

Resolves #1921
Depends on #1928

@xmnlab xmnlab self-assigned this Aug 20, 2019
@xmnlab xmnlab added bug Incorrect behavior inside of ibis omnisci labels Aug 20, 2019
@xmnlab xmnlab changed the title Fixed explain method BUG: Fixes explain operation Aug 20, 2019
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #1933 into master will decrease coverage by 1.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1933      +/-   ##
==========================================
- Coverage   87.46%   86.24%   -1.22%     
==========================================
  Files          89       93       +4     
  Lines       16405    17177     +772     
  Branches     2093     2244     +151     
==========================================
+ Hits        14349    14815     +466     
- Misses       1660     1958     +298     
- Partials      396      404       +8
Impacted Files Coverage Δ
ibis/omniscidb/client.py 60.55% <100%> (+0.33%) ⬆️
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/bigquery/compiler.py 59.92% <0%> (-37.5%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.23% <0%> (-5.2%) ⬇️
ibis/pandas/client.py 85.54% <0%> (-3.47%) ⬇️
ibis/bigquery/api.py 63.33% <0%> (-3.34%) ⬇️
ibis/expr/schema.py 89.77% <0%> (-1.14%) ⬇️
ibis/sql/compiler.py 94.26% <0%> (-0.39%) ⬇️
ibis/expr/api.py 92.33% <0%> (-0.37%) ⬇️
... and 9 more

ibis/omniscidb/client.py Outdated Show resolved Hide resolved
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @xmnlab.

@cpcloud cpcloud added this to the Next Major Release milestone Aug 22, 2019
@cpcloud cpcloud merged commit 3dd744a into ibis-project:master Aug 22, 2019
@xmnlab xmnlab deleted the fix-explain branch August 22, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OmniSciDB explain: OmniSciIbisClient object has no attribute _get_list
2 participants