Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix incorrect assumptions about attached SQLite databases #1937

Merged
merged 5 commits into from
Aug 22, 2019

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 21, 2019

No description provided.

@cpcloud cpcloud requested a review from xmnlab August 21, 2019 22:35
@cpcloud cpcloud added bug Incorrect behavior inside of ibis sqlalchemy SQLAlchemy-based backends labels Aug 21, 2019
@cpcloud cpcloud added this to the Next Major Release milestone Aug 21, 2019
@xmnlab
Copy link
Contributor

xmnlab commented Aug 21, 2019

@cpcloud maybe you could try openjdk-8-jre to openjdk-11-jre on Dockerfile.dev

Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpcloud LGTM! thanks for working on that!

@cpcloud cpcloud force-pushed the sqlite-sqlalchemy branch 3 times, most recently from 472deca to 06b75b8 Compare August 22, 2019 14:15
@cpcloud cpcloud self-assigned this Aug 22, 2019
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #1937 into master will decrease coverage by 1.84%.
The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1937      +/-   ##
==========================================
- Coverage   87.46%   85.62%   -1.85%     
==========================================
  Files          89       89              
  Lines       16405    16419      +14     
  Branches     2093     2094       +1     
==========================================
- Hits        14349    14059     -290     
- Misses       1660     1958     +298     
- Partials      396      402       +6
Impacted Files Coverage Δ
ibis/sql/alchemy.py 92.28% <100%> (-0.35%) ⬇️
ibis/sql/sqlite/client.py 92.25% <100%> (+0.42%) ⬆️
ibis/sql/postgres/client.py 80.95% <80%> (ø) ⬆️
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/bigquery/compiler.py 59.92% <0%> (-37.5%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/sql/mysql/client.py 63.29% <0%> (-10.13%) ⬇️
ibis/impala/compiler.py 91.23% <0%> (-5.2%) ⬇️
ibis/pandas/dispatch.py 95.45% <0%> (-4.55%) ⬇️
ibis/pandas/client.py 85.54% <0%> (-3.47%) ⬇️
... and 8 more

@cpcloud
Copy link
Member Author

cpcloud commented Aug 22, 2019

This is passing here: https://cpcloud.visualstudio.com/ibis/_build/results?buildId=717 so I'm going to merge.

@cpcloud cpcloud merged commit b748593 into ibis-project:master Aug 22, 2019
@cpcloud cpcloud deleted the sqlite-sqlalchemy branch August 22, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis sqlalchemy SQLAlchemy-based backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants