-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix incorrect assumptions about attached SQLite databases #1937
Conversation
|
@cpcloud maybe you could try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpcloud LGTM! thanks for working on that!
472deca
to
06b75b8
Compare
d14e735
to
c9e5d72
Compare
Codecov Report
@@ Coverage Diff @@
## master #1937 +/- ##
==========================================
- Coverage 87.46% 85.62% -1.85%
==========================================
Files 89 89
Lines 16405 16419 +14
Branches 2093 2094 +1
==========================================
- Hits 14349 14059 -290
- Misses 1660 1958 +298
- Partials 396 402 +6
|
|
This is passing here: https://cpcloud.visualstudio.com/ibis/_build/results?buildId=717 so I'm going to merge. |
No description provided.