Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Upgrade to JDK11 #1938

Merged
merged 6 commits into from
Aug 22, 2019
Merged

BUG: Upgrade to JDK11 #1938

merged 6 commits into from
Aug 22, 2019

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 21, 2019

Closes #1936

@cpcloud cpcloud added this to the Next Major Release milestone Aug 21, 2019
@cpcloud cpcloud added bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs labels Aug 21, 2019
@cpcloud cpcloud self-assigned this Aug 21, 2019
@cpcloud cpcloud requested a review from xmnlab August 21, 2019 23:21
@xmnlab
Copy link
Contributor

xmnlab commented Aug 21, 2019

it seems it has some conflict with spark

xmnlab
xmnlab reviewed Aug 22, 2019
View reviewed changes
ci/Dockerfile.dev Outdated Show resolved Hide resolved
xmnlab
xmnlab reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@xmnlab xmnlab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpcloud maybe installing openjdk from conda could work

@codecov
Copy link

codecov bot commented Aug 22, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9df2795). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1938   +/-   ##
=========================================
  Coverage          ?   85.75%           
=========================================
  Files             ?       89           
  Lines             ?    16405           
  Branches          ?     2093           
=========================================
  Hits              ?    14068           
  Misses            ?     1943           
  Partials          ?      394

@cpcloud cpcloud mentioned this pull request Aug 22, 2019
Merged
@cpcloud cpcloud merged commit 277ff1b into ibis-project:master Aug 22, 2019
@cpcloud cpcloud deleted the fix-miniconda branch October 21, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab xmnlab left review comments

Assignees

@cpcloud cpcloud

Labels
bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: CI is failing due the new continuumio/miniconda3:latest
2 participants
@cpcloud @xmnlab