Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: PySpark backend string and column ops #1942

Merged
merged 5 commits into from
Sep 3, 2019

Conversation

hjoo
Copy link
Contributor

@hjoo hjoo commented Aug 30, 2019

This PR implements column operations and string operations for the PySpark backend to pass all/test_column.py and all/test_string.py tests.

String operations not implemented and skipped:

  • find_in_set - no equivalent behavior in Pyspark

Copy link
Contributor

@DiegoAlbertoTorres DiegoAlbertoTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback added feature Features or general enhancements spark labels Sep 3, 2019
@jreback jreback added this to the Next Feature Release milestone Sep 3, 2019
@jreback jreback merged commit ffe68dd into ibis-project:master Sep 3, 2019
@jreback
Copy link
Contributor

jreback commented Sep 3, 2019

thanks @hjoo nice adds!

costrouc pushed a commit to costrouc/ibis that referenced this pull request Oct 10, 2019
* implement pyspark string ops and compiler distinct column op to pass all/test_string.py and all/test_column.py

* fix string tests to xfail on backends

* switch upper, lower, reverse, and length string functions to use Spark native functions

* switch strip, lstrip, rstrip, capitalize string functions to use Spark native functions

* remove unused pandas_udf import statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants