ENH: filter for PySpark backend #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1943 +/- ##
==========================================
- Coverage 87.77% 86.13% -1.64%
==========================================
Files 93 93
Lines 17068 17088 +20
Branches 2157 2159 +2
==========================================
- Hits 14981 14719 -262
- Misses 1679 1964 +285
+ Partials 408 405 -3
|
toryhaavik
reviewed
Sep 6, 2019
|
Most recent push is a rebase on top of master. |
xmnlab
reviewed
Sep 7, 2019
|
This LGTM, @hjoo please just rebase on top of master, and i'll merge on green |
|
Rebase complete |
costrouc
pushed a commit
to costrouc/ibis
that referenced
this pull request
Oct 10, 2019
Introduces predicate handling in `ops.Selection` for `filter()` functionality. Also implemented a few missing comparison operations: - `And` - `Or` - `NotEquals` - `Less` - `LessEquals` Author: Hyonjee <hyonjee.joo@twosigma.com> Closes ibis-project#1943 from hjoo/pyspark-filter and squashes the following commits: 42c2a3c [Hyonjee] parametrize pyspark test_filter 0480921 [Hyonjee] added ibis issue for missing sort_keys handling for pyspark selection op 28e6ad6 [Hyonjee] pyspark backend filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces predicate handling in
ops.Selectionforfilter()functionality.Also implemented a few missing comparison operations:
AndOrNotEqualsLessLessEquals