Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPP: More informative IntegrityError on duplicate columns #1949

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

oasbrink
Copy link
Contributor

@oasbrink oasbrink commented Sep 6, 2019

Closes #1359

@pep8speaks
Copy link

pep8speaks commented Sep 6, 2019

Hello @oasbrink! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-06 15:33:59 UTC

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #1949 into master will decrease coverage by 1.65%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1949      +/-   ##
==========================================
- Coverage   87.67%   86.01%   -1.66%     
==========================================
  Files          93       93              
  Lines       16968    16971       +3     
  Branches     2144     2145       +1     
==========================================
- Hits        14876    14598     -278     
- Misses       1683     1966     +283     
+ Partials      409      407       -2
Impacted Files Coverage Δ
ibis/expr/schema.py 90.1% <100%> (-0.8%) ⬇️
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/bigquery/compiler.py 59.92% <0%> (-37.5%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.23% <0%> (-5.2%) ⬇️
ibis/pandas/client.py 85.54% <0%> (-3.47%) ⬇️
ibis/bigquery/api.py 63.33% <0%> (-3.34%) ⬇️
ibis/sql/compiler.py 94.26% <0%> (-0.39%) ⬇️
ibis/expr/api.py 92.33% <0%> (-0.37%) ⬇️

@toryhaavik toryhaavik self-assigned this Sep 6, 2019
@toryhaavik toryhaavik self-requested a review September 6, 2019 18:43
@toryhaavik toryhaavik merged commit 16ad3ee into ibis-project:master Sep 6, 2019
costrouc pushed a commit to costrouc/ibis that referenced this pull request Oct 10, 2019
Closes ibis-project#1359
Author: Olof Asbrink <oasbrink@twosigma.com>

Closes ibis-project#1949 from oasbrink/warning and squashes the following commits:

023228c [Olof Asbrink] SUPP: More informative IntegrityError on duplicate columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More informative IntegrityError on duplicate columns
3 participants