Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPP: Remove pandas deprecation warnings #1950

Merged
merged 1 commit into from
Sep 7, 2019

Conversation

toryhaavik
Copy link
Contributor

Closes #1946

@toryhaavik toryhaavik added the pandas The pandas backend label Sep 6, 2019
@toryhaavik toryhaavik force-pushed the pandas-dep branch 2 times, most recently from 75dfa12 to 7b42a81 Compare September 6, 2019 17:57
@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #1950 into master will decrease coverage by 3.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1950      +/-   ##
==========================================
- Coverage   87.67%   84.39%   -3.28%     
==========================================
  Files          93       93              
  Lines       16968    16968              
  Branches     2144     2144              
==========================================
- Hits        14876    14320     -556     
- Misses       1683     2237     +554     
- Partials      409      411       +2
Impacted Files Coverage Δ
ibis/pandas/execution/generic.py 85.01% <100%> (-0.45%) ⬇️
ibis/sql/postgres/udf/api.py 32.78% <0%> (-57.38%) ⬇️
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/common/geospatial.py 31.39% <0%> (-50%) ⬇️
ibis/bigquery/compiler.py 59.92% <0%> (-37.5%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/expr/api.py 82.96% <0%> (-9.74%) ⬇️
ibis/omniscidb/client.py 52.5% <0%> (-8.06%) ⬇️
ibis/sql/alchemy.py 87.31% <0%> (-5.21%) ⬇️
ibis/impala/compiler.py 91.23% <0%> (-5.2%) ⬇️
... and 9 more

Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@xmnlab xmnlab merged commit 174ab8e into ibis-project:master Sep 7, 2019
costrouc pushed a commit to costrouc/ibis that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pandas The pandas backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve deprecation warnings
2 participants