Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add more geospatial ops for OmniSciDB #1958

Merged
merged 3 commits into from
Sep 7, 2019
Merged

ENH: Add more geospatial ops for OmniSciDB #1958

merged 3 commits into from
Sep 7, 2019

Conversation

ian-r-rose
Copy link
Contributor

This adds a few geospatial ops to the omniscidb backend (probably added since the last time there was a pass through geospatial ops).

  • ST_DWithin
  • ST_Intersects
  • ST_Disjoint

@pep8speaks
Copy link

pep8speaks commented Sep 6, 2019 •
edited
Loading

Hello @ian-r-rose! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-07 17:53:05 UTC

@ian-r-rose ian-r-rose changed the title Missing geospatial ops Missing geospatial ops for OmniSciDB Sep 6, 2019
@xmnlab
Copy link
Contributor

xmnlab commented Sep 7, 2019

hey @ian-r-rose it seems lint check is failing
have you executed make develop? that is pretty helpful because it add back, flake8 and isort as git pre-commit hook

@ian-r-rose
Copy link
Contributor Author

That flake8 failure is not a line I touched :/

I have run make develop, but it's currently broken in my env.

@xmnlab
Copy link
Contributor

xmnlab commented Sep 7, 2019

is it raising any error message? or it just doesn't work?

@ian-r-rose
Copy link
Contributor Author

ian-r-rose commented Sep 7, 2019 •
edited
Loading

isort failing with ValueError: failed to parse CPython sys.version: '3.7.3 (default, Mar 27 2019, 22:11:17) \n[GCC 7.3.0]'. Not sure where the problem is, but I was willing to chalk it up to a broken environment :)

xmnlab
xmnlab approved these changes Sep 7, 2019
View reviewed changes
Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ian-r-rose that LGTM! thanks!

@xmnlab xmnlab merged commit 4b3b07e into ibis-project:master Sep 7, 2019
@xmnlab xmnlab changed the title Missing geospatial ops for OmniSciDB ENH: Add more geospatial ops for OmniSciDB Sep 7, 2019
@xmnlab xmnlab mentioned this pull request Sep 7, 2019
Closed
6 tasks
@ian-r-rose ian-r-rose mentioned this pull request Oct 7, 2019
Merged
costrouc pushed a commit to costrouc/ibis that referenced this pull request Oct 10, 2019
@ian-r-rose @costrouc
Missing geospatial ops for OmniSciDB (ibis-project#1958)
be639aa 
* Add omniscidb ops for intersects, disjoint, dwithin, and dfullywithin.

* Add some tests for dwithin, dfullywithin, intersects, disjoint.

* Back off of dfullywithin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab xmnlab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-r-rose @pep8speaks @xmnlab