Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Developer doc enhancements #1960

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

toryhaavik
Copy link
Contributor

Closes #1956

@toryhaavik toryhaavik added the docs Documentation related issues or PRs label Sep 9, 2019
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #1960 into master will decrease coverage by 1.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1960      +/-   ##
==========================================
- Coverage   87.76%   86.14%   -1.63%     
==========================================
  Files          93       93              
  Lines       17088    17088              
  Branches     2159     2159              
==========================================
- Hits        14997    14720     -277     
- Misses       1683     1963     +280     
+ Partials      408      405       -3
Impacted Files Coverage Δ
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/bigquery/compiler.py 59.92% <0%> (-37.5%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.23% <0%> (-5.2%) ⬇️
ibis/pandas/client.py 85.54% <0%> (-3.47%) ⬇️
ibis/bigquery/api.py 63.33% <0%> (-3.34%) ⬇️
ibis/expr/schema.py 90.1% <0%> (-1.1%) ⬇️
ibis/sql/compiler.py 94.26% <0%> (-0.39%) ⬇️
ibis/expr/api.py 92.33% <0%> (-0.37%) ⬇️
ibis/impala/client.py 78.27% <0%> (+0.5%) ⬆️

@xmnlab
Copy link
Contributor

xmnlab commented Sep 9, 2019

@toryhaavik that looks pretty good. should it contain information about numpy docstring default?

@toryhaavik
Copy link
Contributor Author

@xmnlab sure, that's a good one, i'll add that in now.

@xmnlab
Copy link
Contributor

xmnlab commented Sep 9, 2019

@toryhaavik looks great! thanks for working on that.

@xmnlab xmnlab merged commit 105d971 into ibis-project:master Sep 9, 2019
costrouc pushed a commit to costrouc/ibis that referenced this pull request Oct 10, 2019
Closes ibis-project#1956
Author: Tory Haavik <tory.haavik@twosigma.com>

Closes ibis-project#1960 from toryhaavik/more-dev-docs and squashes the following commits:

3235f71 [Tory Haavik] DOC: Developer doc enhancements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer doc enhancements
2 participants