Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPP: Disable BigQuery explicitly in all/test_join.py #1971

Merged
merged 2 commits into from
Sep 18, 2019
Merged

SUPP: Disable BigQuery explicitly in all/test_join.py #1971

merged 2 commits into from
Sep 18, 2019

Conversation

icexelloss
Copy link
Contributor

Strangely, pytest.mark.only_on_backends doesn't skip BigQuery, so I added an explicit skip as a workaround.

@icexelloss
Copy link
Contributor Author

cc @toryhaavik

@icexelloss icexelloss changed the title Disable test join bigquery SUPP: Disable BigQuery explicitly in all/test_join.py Sep 18, 2019
toryhaavik
toryhaavik approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@toryhaavik toryhaavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's annoying. thanks for fixing

@toryhaavik toryhaavik merged commit 5653f4d into ibis-project:master Sep 18, 2019
@icexelloss icexelloss mentioned this pull request Sep 18, 2019
Merged
costrouc pushed a commit to costrouc/ibis that referenced this pull request Oct 10, 2019
@icexelloss @costrouc
SUPP: Disable BigQuery explicitly in all/test_join.py
e4e9306 
Strangely, `pytest.mark.only_on_backends` doesn't skip BigQuery, so I
added an explicit skip as a workaround.
Author: Li Jin <ice.xelloss@gmail.com>

Closes ibis-project#1971 from icexelloss/disable-test-join-bigquery and squashes the following commits:

121175d [Li Jin] Fix comments
dcdd73f [Li Jin] SUPP: Disable BigQuery explicitly in all/test_join.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toryhaavik toryhaavik toryhaavik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icexelloss @toryhaavik