SUPP: Fix BigQuery backend fixture so batting and awards_players fixture re… #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turns None instead of throwing exception
|
cc @toryhaavik Sorry #1971 Doesn't actually fix the issue. Unfortunately I don't know how to set up local environment for testing big query but I think this should fix it. |
toryhaavik
approved these changes
Sep 19, 2019
costrouc
pushed a commit
to costrouc/ibis
that referenced
this pull request
Oct 10, 2019
…ure re… …turns None instead of throwing exception Author: Li Jin <ice.xelloss@gmail.com> Closes ibis-project#1972 from icexelloss/fix-test-join-bigquery and squashes the following commits: 46f5f84 [Li Jin] Fix BigQuery backend fixture so batting and awards_players fixture returns None instead of throwing exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…turns None instead of throwing exception