ENH: Add support for params, query_schema, and sql in PySpark backend #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @hjoo @toryhaavik |
icexelloss
changed the title
|
Gentle ping @toryhaavik |
toryhaavik
suggested changes
Sep 24, 2019
toryhaavik
reviewed
Sep 25, 2019
icexelloss
force-pushed
the
pyspark-backend-test-param
branch
from
266ffa2
to
ab5db4e
Compare
toryhaavik
approved these changes
Sep 25, 2019
costrouc
pushed a commit
to costrouc/ibis
that referenced
this pull request
Oct 10, 2019
Pass ibis/all/test_client.py and ibis/all/test_params.py test_params.py is partially supported Author: Li Jin <ice.xelloss@gmail.com> Closes ibis-project#1973 from icexelloss/pyspark-backend-test-param and squashes the following commits: ab5db4e [Li Jin] FEAT: Add support for params, query_schema, and sql in PySpark backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass ibis/all/test_client.py and ibis/all/test_params.py
test_params.py is partially supported