Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Implement sort, if_null, null_if and notin for PySpark backend #1978

Merged

Conversation

icexelloss
Copy link
Contributor

Passes all/test_generic.py and also fixes #1957

@icexelloss
Copy link
Contributor Author

cc @toryhaavik @hjoo

Copy link
Contributor

@toryhaavik toryhaavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll get the pipeline to pass and merge!

@toryhaavik toryhaavik merged commit 9e410f8 into ibis-project:master Sep 27, 2019
costrouc pushed a commit to costrouc/ibis that referenced this pull request Oct 10, 2019
Passes all/test_generic.py and also fixes ibis-project#1957
Author: Li Jin <ice.xelloss@gmail.com>

Closes ibis-project#1978 from icexelloss/pyspark-backend-test-generic and squashes the following commits:

4242765 [Li Jin] ENH: Implement sort, if_null, null_if and notin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: implement sort_keys for PySpark backend selection operation
2 participants