FEAT: Add more POSTGIS operations #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmnlab
reviewed
Oct 14, 2019
There was a problem hiding this comment.
hey @ian-r-rose I added some comments related to docstring.
I am working to fix all docstrings issues in the code and also add docstring checks inside CI.
for now for your code if you want to check you can run:
pydocstyle --convention=numpy PATH_OF_THE_FILE_YOU_WANT_TO_CHECK.py
probably first you need to fix an issue with setup.cfg:
diff --git a/setup.cfg b/setup.cfg
index 124f3c83..d00b8a63 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -14,7 +14,6 @@ exclude = build,dist,docs,versioneer.py,ibis/_version.py,.git,__pycache__,.tox,.
[pydocstyle]
ignore = D105,D107
inherit = false
-match = *.py
[isort]
line_length = 79
|
Thanks for taking a look @xmnlab, I've made the requested changes to the docstrings. |
xmnlab
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1787 and #1925 . This adds a number of new operations for the PostGIS backend:
ST_GeometryTypeST_GeometryNST_IsValidST_LineLocatePointST_LineMergeST_LineSubstringST_OrderingEqualsST_UnionThe last one requires special attention. That
ST_Unionis available as both a value operation and a column aggregation operation. To avoid a name collision in the ibis APIs, I have named the aggregation variantunary_union. This is following the same choice made by GeoPandas.