SUPP: Add black step to CI #1988
Conversation
There was a problem hiding this comment.
thanks @toryhaavik for working on that!
I just added a comment about pip section.
ci/requirements-3.6-dev.yml
Outdated
| @@ -1,7 +1,7 @@ | |||
| channels: | |||
| - conda-forge | |||
| dependencies: | |||
| - black | |||
| - git+git://github.com/psf/black@40e8b3a231bade22d838858435a33d60a8325306#egg=black # see .pre-commit-config.yaml, we pin to a specific version of black | |||
There was a problem hiding this comment.
this probably should be in a pip section.
at the end, inside the pip section after - seed-isort-config you can add:
- git+https://github.com/psf/black.git@40e8b3a231bade22d838858435a33d60a8325306
- git+https://github.com/timothycrosley/isort.git@18ad293fc9d1852776afe35015a932b68d26fb14
also we need a specific version of isort
There was a problem hiding this comment.
Thanks! I should have seen the pip section before...
ci/requirements-3.7-dev.yml
Outdated
| @@ -1,7 +1,7 @@ | |||
| channels: | |||
| - conda-forge | |||
| dependencies: | |||
| - black | |||
| - git+git://github.com/psf/black@40e8b3a231bade22d838858435a33d60a8325306#egg=black # see .pre-commit-config.yaml, we pin to a specific version of black | |||
There was a problem hiding this comment.
see the previous comment about pip section
|
Ha! the pipeline failed correctly :D. There are some formatting changes that need to be made, i'll add them to this review. |
|
@toryhaavik that is awesome! It seems black is not available inside the CI for linux/python 3.5: |
|
Oh yeah, because black doesn't work on py35. I'll have to add a conditional to check version |
Closes ibis-project#1966 Author: Tory Haavik <tory.haavik@twosigma.com> Closes ibis-project#1988 from toryhaavik/black and squashes the following commits: 2073b2e [Tory Haavik] Fix variables e5db7c7 [Tory Haavik] Apply black formatting b82bc09 [Tory Haavik] SUPP: Add black step to CI to ensure any proposed changes are already blackened
Closes #1966