Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geospatial tutorial notebook. #1991

Merged
merged 2 commits into from
Nov 17, 2019

Conversation

ian-r-rose
Copy link
Contributor

This adds a demo/tutorial notebook for some of the geospatial stuff that @xmnlab and I have worked on in #1666, #1958, #1786, #1925, #1987

@xmnlab xmnlab self-requested a review October 28, 2019 23:40
@xmnlab
Copy link
Contributor

xmnlab commented Oct 29, 2019

@ian-r-rose sorry for the delay .. I started to review this. thanks for working on that.

@xmnlab
Copy link
Contributor

xmnlab commented Nov 9, 2019

@ian-r-rose sorry for the delay.

it looks nice!

it uses a non public database connection for this, right?

@jreback @scottcode any thought about this?

@scottcode
Copy link
Contributor

Cool-looking tutorial, @ian-r-rose!

It looks like the data is downloadable from the geofabrik link in the notebook. But from the notebook's comments alone, it's still a little unclear to me how to load the data. @ian-r-rose, could you add more instructions in the notebook about how to download, transform (if necessary) and load the data in order to go through the tutorial?

The data set seems rather large (~600MB). That might make testing or trying it out a little harder. Is there an even smaller extract that could be used?

@ian-r-rose
Copy link
Contributor Author

Thanks for the review @scottcode. Yes, the data is large-ish, certainly too big to be included in the repo. I could add some content for how to load it. If memory serves, it takes a few minutes with ogr2ogr).

Another option for this would be to include a link to something like this demo, which is packaged as a live binder. It uses smaller data, but is a bit less focused on ibis.

@ian-r-rose
Copy link
Contributor Author

I've updated this to include instructions for setting up a demonstration database and loading the OSM extract into it.

It does take some time, as the dataset is not small, but I don't think it's too outlandish.

@ian-r-rose
Copy link
Contributor Author

Rebased

@jreback jreback added this to the Next Feature Release milestone Nov 17, 2019
@jreback jreback merged commit 95f1518 into ibis-project:master Nov 17, 2019
@jreback
Copy link
Contributor

jreback commented Nov 17, 2019

thanks @ian-r-rose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants