ENH: Clean up window translation logic in pyspark backend #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @hjoo @toryhaavik |
icexelloss
force-pushed
the
pyspark-backend-window-op-refactor
branch
2 times, most recently
from
9c61c8f
to
259a801
Compare
icexelloss
force-pushed
the
pyspark-backend-window-op-refactor
branch
from
259a801
to
8e2790b
Compare
xmnlab
suggested changes
Oct 25, 2019
There was a problem hiding this comment.
@icexelloss thanks for working on that!
As we are using docstring with numpy format, could you provide these docstrings?
I hope in a near feature CI will do the docstring checks :)
jreback
approved these changes
Oct 27, 2019
| @@ -1040,12 +1013,12 @@ def compile_lead(t, expr, scope, *, window, **kwargs): | |||
|
|
|||
| @compiles(ops.MinRank) | |||
| def compile_rank(t, expr, scope, *, window, **kwargs): | |||
| return F.rank().over(window).astype('long') - F.lit(1) | |||
There was a problem hiding this comment.
for my own edification, what does F.lit(1) do in pyspark?
There was a problem hiding this comment.
F.lit(1) creates a constant literal column of "1"s
xmnlab
approved these changes
Oct 31, 2019
There was a problem hiding this comment.
LGTM. @icexelloss thanks for working on that.
related to my comments for docstring, no worry about that now.
I am working now to fix that.
|
Thanks @xmnlab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some code duplication in the current pyspark compiler. I cleaned up a bit.