Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix pydocstyle config #2010

Merged
merged 1 commit into from
Oct 28, 2019
Merged

BUG: Fix pydocstyle config #2010

merged 1 commit into from
Oct 28, 2019

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Oct 25, 2019 •
edited
Loading

This PR fix the pydocstyle config.

@xmnlab xmnlab changed the title Fixed pydocstyle config. BUG: Fix pydocstyle config Oct 25, 2019
@xmnlab
Copy link
Contributor Author

xmnlab commented Oct 28, 2019

@jreback @toryhaavik @scottcode when you have time could you review this PR?

toryhaavik
toryhaavik approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@toryhaavik toryhaavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toryhaavik toryhaavik merged commit 4b0c127 into ibis-project:master Oct 28, 2019
@xmnlab xmnlab deleted the fix-pydocstyle-conf branch October 28, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toryhaavik toryhaavik toryhaavik approved these changes

@jreback jreback Awaiting requested review from jreback

@scottcode scottcode Awaiting requested review from scottcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmnlab @toryhaavik