Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape column names and types in png_repr. #2023

Merged
merged 2 commits into from Nov 17, 2019

Conversation

@ian-r-rose
Copy link
Contributor

ian-r-rose commented Nov 5, 2019

Fixes #2022

@ian-r-rose

This comment has been minimized.

Copy link
Contributor Author

ian-r-rose commented Nov 5, 2019

I don't understand the docs error, but it doesn't look related to me.

@xmnlab

This comment has been minimized.

Copy link
Collaborator

xmnlab commented Nov 9, 2019

@ian-r-rose it seems it is a problem with a sphinx #2024 (comment)

@ian-r-rose ian-r-rose force-pushed the ian-r-rose:escape-html branch from 58f7fbd to 76b67c6 Nov 17, 2019
@ian-r-rose

This comment has been minimized.

Copy link
Contributor Author

ian-r-rose commented Nov 17, 2019

Rebased

Copy link
Contributor

jreback left a comment

lgtm. can you add a release note in docs/source/release.rst; ping on green.

@jreback jreback added the bug label Nov 17, 2019
@jreback jreback added this to the Next Feature Release milestone Nov 17, 2019
@ian-r-rose ian-r-rose force-pushed the ian-r-rose:escape-html branch from b10a092 to 9f2b1b6 Nov 17, 2019
@ian-r-rose

This comment has been minimized.

Copy link
Contributor Author

ian-r-rose commented Nov 17, 2019

green

Copy link
Contributor

jreback left a comment

thanks @ian-r-rose

@jreback jreback merged commit 2157354 into ibis-project:master Nov 17, 2019
10 checks passed
10 checks passed
ibis-project.ibis Build #20191117.5 succeeded
Details
ibis-project.ibis (LinuxBenchmark) LinuxBenchmark succeeded
Details
ibis-project.ibis (LinuxBuildConda) LinuxBuildConda succeeded
Details
ibis-project.ibis (LinuxBuildDocs) LinuxBuildDocs succeeded
Details
ibis-project.ibis (LinuxTest py35) LinuxTest py35 succeeded
Details
ibis-project.ibis (LinuxTest py36) LinuxTest py36 succeeded
Details
ibis-project.ibis (LinuxTest py37) LinuxTest py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details
@ian-r-rose ian-r-rose deleted the ian-r-rose:escape-html branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.