Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape column names and types in png_repr. #2023

Merged
merged 2 commits into from
Nov 17, 2019
Merged

Escape column names and types in png_repr. #2023

merged 2 commits into from
Nov 17, 2019

Conversation

ian-r-rose
Copy link
Contributor

Fixes #2022

@ian-r-rose
Copy link
Contributor Author

I don't understand the docs error, but it doesn't look related to me.

@xmnlab
Copy link
Contributor

xmnlab commented Nov 9, 2019

@ian-r-rose it seems it is a problem with a sphinx #2024 (comment)

@ian-r-rose
Copy link
Contributor Author

Rebased

jreback
jreback suggested changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. can you add a release note in docs/source/release.rst; ping on green.

@jreback jreback added the bug Incorrect behavior inside of ibis label Nov 17, 2019
@jreback jreback added this to the Next Feature Release milestone Nov 17, 2019
@ian-r-rose
Copy link
Contributor Author

green

jreback
jreback approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ian-r-rose

@jreback jreback merged commit 2157354 into ibis-project:master Nov 17, 2019
@ian-r-rose ian-r-rose deleted the escape-html branch November 18, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Graphviz repr should escape HTML
3 participants
@ian-r-rose @xmnlab @jreback