Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/CI: Fix doc build ci, fix mysql container over HDD and fix doc section inside Makefile #2030

Merged
merged 8 commits into from Nov 16, 2019

Conversation

@xmnlab
Copy link
Collaborator

xmnlab commented Nov 16, 2019

In this PR:

  • fix documentation build CI issue related to semantic_version (Resolves #2027)
  • fixed doc section inside Makefile
  • skip mysql tzinfo (see: docker-library/mariadb#262)
@xmnlab xmnlab changed the title CI: Fix doc build ci and change mysql default port WIP CI: Fix doc build ci and change mysql default port Nov 16, 2019
xmnlab added 3 commits Nov 16, 2019
@scottcode

This comment has been minimized.

Copy link
Collaborator

scottcode commented Nov 16, 2019

@xmnlab Thanks for the work on all these different issues! This addresses a lot of very different and independent issues. Should we consider splitting this up into separate pull requests divided into more cohesive chunks. For example:

  1. Doc fixes (Makefile and semantic_version pin)
  2. MySQL-related fixes
  3. updated omniscidb image
@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

xmnlab commented Nov 16, 2019

@scottcode it sounds good.
but I think that skip mysql tzinfo should be here .. because without that I cannot test it locally.

@scottcode

This comment has been minimized.

Copy link
Collaborator

scottcode commented Nov 16, 2019

@scottcode it sounds good.
but I think that skip mysql tzinfo should be here .. because without that I cannot test it locally.

Makes sense, @xmnlab. Thanks for splitting out the things that doc build fix doesn't depend on.

@scottcode scottcode self-requested a review Nov 16, 2019
Copy link
Collaborator

scottcode left a comment

Now with the narrowed scope, this all looks good to me

@scottcode

This comment has been minimized.

Copy link
Collaborator

scottcode commented Nov 16, 2019

Since I don't write access to the project, my approval doesn't enable the merge. Someone else with write privs will need to approve and merge.

@jreback jreback added the ci label Nov 16, 2019
@jreback jreback added this to the Next Feature Release milestone Nov 16, 2019
@@ -10,3 +10,5 @@ pyarrow>=0.12
sphinx=2.0.1
sphinx-releases
sphinx_rtd_theme
# https://github.com/ibis-project/ibis/issues/2027

This comment has been minimized.

Copy link
@jreback

jreback Nov 16, 2019

Contributor

what is pulling this in now?

This comment has been minimized.

Copy link
@jreback

jreback Nov 16, 2019

Contributor

i would create an issue to remove this pin when the underlying issue is resolved.

This comment has been minimized.

Copy link
@scottcode

scottcode Nov 16, 2019

Collaborator

sphinx-releases has an issue that a change in semantic_version caused. You're right, we should have another issue to remove the pin when it gets fixed.

This comment has been minimized.

Copy link
@scottcode

scottcode Nov 16, 2019

Collaborator

I just created an issue to unpin semantic_version once the issue is fixed (#2033)

This comment has been minimized.

Copy link
@xmnlab

xmnlab Nov 16, 2019

Author Collaborator

thanks @scottcode ! I adding a release note now here.

This comment has been minimized.

Copy link
@jreback

jreback Nov 16, 2019

Contributor

@xmnlab ok, lgtm. ping when ready.

@@ -8,6 +8,7 @@ Release Notes
notes for pre-1.0 versions of ibis can be found at :doc:`/release-pre-1.0`

* :release:`1.2.1 <pending>`
* :bug:`2030` Fix LinuxBuildDocs issue related to semantic_version, fix doc section inside Makefile and skip mysql tzinfo on CI

This comment has been minimized.

Copy link
@jreback

jreback Nov 16, 2019

Contributor

from a user point of view this is not very useful. what IS useful and worth mentioning, is that we now have a pin in the docs build (its not really user, but developer user here)

This comment has been minimized.

Copy link
@xmnlab

xmnlab Nov 16, 2019

Author Collaborator

sounds good. I updated the release note. let me know if it needs any other change.

@xmnlab xmnlab changed the title WIP CI: Fix doc build ci and change mysql default port CI: Fix doc build ci and change mysql default port Nov 16, 2019
@xmnlab xmnlab changed the title CI: Fix doc build ci and change mysql default port BUG/CI: Fix doc build ci and change mysql default port Nov 16, 2019
Copy link
Contributor

jreback left a comment

thanks @xmnlab ping on green.

@xmnlab xmnlab changed the title BUG/CI: Fix doc build ci and change mysql default port BUG/CI: Fix doc build ci, fix mysql container over HDD and fix doc section inside Makefile Nov 16, 2019
@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

xmnlab commented Nov 16, 2019

green :)

@jreback jreback merged commit a6bdbdd into ibis-project:master Nov 16, 2019
10 checks passed
10 checks passed
ibis-project.ibis Build #20191116.11 succeeded
Details
ibis-project.ibis (LinuxBenchmark) LinuxBenchmark succeeded
Details
ibis-project.ibis (LinuxBuildConda) LinuxBuildConda succeeded
Details
ibis-project.ibis (LinuxBuildDocs) LinuxBuildDocs succeeded
Details
ibis-project.ibis (LinuxTest py35) LinuxTest py35 succeeded
Details
ibis-project.ibis (LinuxTest py36) LinuxTest py36 succeeded
Details
ibis-project.ibis (LinuxTest py37) LinuxTest py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

jreback commented Nov 16, 2019

thanks @xmnlab

@jreback

This comment has been minimized.

Copy link
Contributor

jreback commented Nov 16, 2019

rebase the other PRs and we'll get em in

@xmnlab xmnlab deleted the Quansight:fix-docstring-ci branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.