Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPP: Drop support for python 3.5 #2037

Merged
merged 2 commits into from
Nov 26, 2019
Merged

SUPP: Drop support for python 3.5 #2037

merged 2 commits into from
Nov 26, 2019

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Nov 21, 2019 •
edited
Loading

In this PR:

@xmnlab xmnlab changed the title Drop support for python 3.5 SUPP: Drop support for python 3.5 Nov 21, 2019
@xmnlab xmnlab marked this pull request as ready for review November 21, 2019 19:54
@xmnlab xmnlab mentioned this pull request Nov 25, 2019
Closed
scottcode
scottcode approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@scottcode scottcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmnlab Thanks for going through and removing all the version checks. Looks pretty straightforward, even though it affected a lot of files.

@jreback jreback added the compatibility Compatibility related issues or PRs label Nov 26, 2019
@jreback jreback added this to the Next Feature Release milestone Nov 26, 2019
@jreback jreback merged commit d328b94 into ibis-project:master Nov 26, 2019
@jreback
Copy link
Contributor

jreback commented Nov 26, 2019

thanks @xmnlab

@jreback jreback mentioned this pull request Nov 26, 2019
Closed
icexelloss added a commit to icexelloss/ibis that referenced this pull request Nov 26, 2019
@icexelloss
Revert "SUPP: Drop support for python 3.5 (ibis-project#2037)"
0ca13fe 
This reverts commit d328b94.
@xmnlab xmnlab deleted the drop-py35-support branch December 21, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottcode scottcode scottcode approved these changes

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
compatibility Compatibility related issues or PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmnlab @jreback @scottcode