BUG: Fix argument in pymapd.connect calling #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semelianova
force-pushed
the
pymapd_connect_bug
branch
from
2e0d97d
to
00a6bb9
Compare
xmnlab
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
LGTM! thanks @semelianova !
could you please add a release note? https://github.com/ibis-project/ibis/blob/master/docs/source/release.rst below the pending release (:release:1.2.1 <pending>)?
pymapd.connect function doesn't have session_id argument so session_id was replaced with sessionid
xmnlab
force-pushed
the
pymapd_connect_bug
branch
from
00a6bb9
to
9f3dc83
Compare
|
release note added. merging on green. thanks @semelianova ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pymapd.connect function doesn't have session_id argument so session_id was
replaced with sessionid