Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix argument in pymapd.connect calling #2041

Merged
merged 2 commits into from Dec 8, 2019

Conversation

@semelianova
Copy link
Contributor

semelianova commented Dec 2, 2019

pymapd.connect function doesn't have session_id argument so session_id was
replaced with sessionid

@semelianova semelianova force-pushed the semelianova:pymapd_connect_bug branch from 2e0d97d to 00a6bb9 Dec 4, 2019
@xmnlab xmnlab self-assigned this Dec 4, 2019
@xmnlab xmnlab added the omnisci label Dec 4, 2019
@xmnlab
xmnlab approved these changes Dec 5, 2019
Copy link
Collaborator

xmnlab left a comment

LGTM! thanks @semelianova !

could you please add a release note? https://github.com/ibis-project/ibis/blob/master/docs/source/release.rst below the pending release (:release:1.2.1 <pending>)?

@xmnlab xmnlab added the bug label Dec 5, 2019
@jreback jreback added this to the Next Feature Release milestone Dec 6, 2019
semelianova and others added 2 commits Dec 2, 2019
pymapd.connect function doesn't have session_id argument so session_id was
replaced with sessionid
@xmnlab xmnlab force-pushed the semelianova:pymapd_connect_bug branch from 00a6bb9 to 9f3dc83 Dec 8, 2019
@xmnlab

This comment has been minimized.

Copy link
Collaborator

xmnlab commented Dec 8, 2019

release note added. merging on green. thanks @semelianova !

@xmnlab xmnlab merged commit fac2019 into ibis-project:master Dec 8, 2019
8 checks passed
8 checks passed
ibis-project.ibis #20191208.3 succeeded
Details
ibis-project.ibis (LinuxBenchmark) LinuxBenchmark succeeded
Details
ibis-project.ibis (LinuxBuildConda) LinuxBuildConda succeeded
Details
ibis-project.ibis (LinuxBuildDocs) LinuxBuildDocs succeeded
Details
ibis-project.ibis (LinuxTest py36) LinuxTest py36 succeeded
Details
ibis-project.ibis (LinuxTest py37) LinuxTest py37 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details
@semelianova semelianova deleted the semelianova:pymapd_connect_bug branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.