Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: [BQ] Implemented covariance in bigquery #2044

Merged
merged 3 commits into from Dec 13, 2019

Conversation

@wabu
Copy link
Contributor

wabu commented Dec 4, 2019

No description provided.

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Dec 4, 2019

Hello @wabu! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-13 10:53:39 UTC
@wabu wabu force-pushed the gameduell:bq-covar branch 2 times, most recently from 3561b4b to 4ab9988 Dec 4, 2019
@icexelloss

This comment has been minimized.

Copy link
Collaborator

icexelloss commented Dec 4, 2019

Hi can you please update [FEAT] to FEAT: in the title?

@jreback jreback added the bigquery label Dec 4, 2019
@jreback jreback added this to the Next Feature Release milestone Dec 4, 2019
@wabu wabu changed the title [FEAT][BQ] Implemented covariance in bigquery FEAT: [BQ] Implemented covariance in bigquery Dec 4, 2019
Copy link
Contributor

jreback left a comment

@wabu lgtm, can you add a note in docs/source/release.rst, does this close an open issue?

@wabu wabu force-pushed the gameduell:bq-covar branch from 4ab9988 to 45087df Dec 4, 2019
@wabu

This comment has been minimized.

Copy link
Contributor Author

wabu commented Dec 4, 2019

There's no issue for this, used the implementation right away and later did a PR for it.

@wabu

This comment has been minimized.

Copy link
Contributor Author

wabu commented Dec 9, 2019

Should I create an issue for this or is it fine for merge like this?

@wabu wabu requested a review from jreback Dec 9, 2019
@xmnlab
xmnlab approved these changes Dec 12, 2019
Copy link
Collaborator

xmnlab left a comment

LGTM @wabu !

@xmnlab

This comment has been minimized.

Copy link
Collaborator

xmnlab commented Dec 12, 2019

could you please resolve the release note conflict?

@jreback jreback merged commit 9d12926 into ibis-project:master Dec 13, 2019
8 checks passed
8 checks passed
ibis-project.ibis #20191213.1 succeeded
Details
ibis-project.ibis (LinuxBenchmark) LinuxBenchmark succeeded
Details
ibis-project.ibis (LinuxBuildConda) LinuxBuildConda succeeded
Details
ibis-project.ibis (LinuxBuildDocs) LinuxBuildDocs succeeded
Details
ibis-project.ibis (LinuxTest py36) LinuxTest py36 succeeded
Details
ibis-project.ibis (LinuxTest py37) LinuxTest py37 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

jreback commented Dec 13, 2019

thanks @wabu

@wabu wabu deleted the gameduell:bq-covar branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.