Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: [BQ] Implemented covariance in bigquery #2044

Merged
merged 3 commits into from
Dec 13, 2019
Merged

FEAT: [BQ] Implemented covariance in bigquery #2044

merged 3 commits into from
Dec 13, 2019

Conversation

wabu
Copy link
Contributor

@wabu wabu commented Dec 4, 2019

No description provided.

@pep8speaks
Copy link

pep8speaks commented Dec 4, 2019 •
edited
Loading

Hello @wabu! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-13 10:53:39 UTC

@wabu wabu force-pushed the bq-covar branch 2 times, most recently from 3561b4b to 4ab9988 Compare December 4, 2019 14:07
@icexelloss
Copy link
Contributor

Hi can you please update [FEAT] to FEAT: in the title?

@jreback jreback added this to the Next Feature Release milestone Dec 4, 2019
@wabu wabu changed the title [FEAT][BQ] Implemented covariance in bigquery FEAT: [BQ] Implemented covariance in bigquery Dec 4, 2019
jreback
jreback suggested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wabu lgtm, can you add a note in docs/source/release.rst, does this close an open issue?

@wabu
Copy link
Contributor Author

wabu commented Dec 4, 2019

There's no issue for this, used the implementation right away and later did a PR for it.

@wabu
Copy link
Contributor Author

wabu commented Dec 9, 2019

Should I create an issue for this or is it fine for merge like this?

@wabu wabu requested a review from jreback December 9, 2019 20:12
xmnlab
xmnlab approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @wabu !

@xmnlab
Copy link
Contributor

xmnlab commented Dec 12, 2019

could you please resolve the release note conflict?

@jreback jreback merged commit 9d12926 into ibis-project:master Dec 13, 2019
@jreback
Copy link
Contributor

jreback commented Dec 13, 2019

thanks @wabu

@wabu wabu deleted the bq-covar branch December 16, 2019 08:27
@anmyachev anmyachev mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@xmnlab xmnlab xmnlab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wabu @pep8speaks @icexelloss @xmnlab @jreback