refactor makefile #2052
Merged
refactor makefile #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
force-pushed
the
impove_usability
branch
from
1cbd555
to
6036047
Compare
xmnlab
approved these changes
Jan 24, 2020
|
hey @jreback if you have time, could you also take a look into this PR pls? |
|
yes |
jreback
suggested changes
Jan 24, 2020
|
@icexelloss if you can try out and see |
|
|
@jreback the PR is ready for review |
anmyachev
force-pushed
the
impove_usability
branch
from
6669106
to
f8077e0
Compare
|
@jreback the PR is ready for review |
jreback
reviewed
Jan 29, 2020
| @@ -2,14 +2,61 @@ | |||
|
|
|||
| SHELL := /bin/bash | |||
| MAKEFILE_DIR = $(patsubst %/,%,$(dir $(abspath $(lastword $(MAKEFILE_LIST))))) | |||
|
|
|||
| # from PYTHON_VERSION depends which `./ci/requirements-$PYTHON_VERSION-dev` file | |||
| # will be used for creating ibis image (see for additional info: `./ci/Dockerfile.dev` | |||
There was a problem hiding this comment.
so these comments are fine, but maybe my question wasn't clear. we use the PYTHON variable inside Dockerfile.dev and NOT PYTHON_VERSION. I think we should simply fix this or is there a reason that is not obvious?
rewrite linux.yml by using 'make' fix make bugs using shell explicit add posibility to run tests for separate services via make tool
anmyachev
force-pushed
the
impove_usability
branch
from
c5601ab
to
4c7016b
Compare
|
thanks @anmyachev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linux.ymlfor usingmakemake initwith concrete servicemake test BACKENDS=omniscidb