Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix cudf import on OmniSciDB backend #2055

Merged
merged 1 commit into from
Jan 29, 2020
Merged

BUG: Fix cudf import on OmniSciDB backend #2055

merged 1 commit into from
Jan 29, 2020

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Jan 28, 2020

Fix #2053

@xmnlab xmnlab mentioned this pull request Jan 28, 2020
Closed
@xmnlab xmnlab added bug Incorrect behavior inside of ibis omnisci labels Jan 28, 2020
@xmnlab xmnlab changed the title Fix cudf import on OmniSciDB backend BUG: Fix cudf import on OmniSciDB backend Jan 28, 2020
@jreback jreback added this to the Next Feature Release milestone Jan 28, 2020
jreback
jreback reviewed Jan 28, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you file an issue upstream for this; importing a module should always raise ImportError and not OSError

ibis/omniscidb/client.py
@@ -20,7 +20,7 @@

try:
from cudf.dataframe.dataframe import DataFrame as GPUDataFrame
except ImportError:
except (ImportError, OSError):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way to add a test for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jreback for reviewing this PR.

sounds good I will open an issue on cudf repo! thanks!

I think that would be very hard to reproduce this error ib ibis CI, as cudf depends on CUDA .. it will be hard to reproduce this environment on ibis CI.

as it is a very small fix, changing CI just for that would be not a good approach (also I am not sure that we can reproduce that on CI)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rapidsai/cudf#3956

@xmnlab xmnlab marked this pull request as ready for review January 28, 2020 02:31
@jreback jreback merged commit 7e6e42a into ibis-project:master Jan 29, 2020
@jreback
Copy link
Contributor

jreback commented Jan 29, 2020

thanks @xmnlab

@xmnlab xmnlab deleted the fix-cudf-import branch December 21, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: [omniscidb] add OSError as an possible exception when importing GPUDataFrame
2 participants
@xmnlab @jreback