BUG: Fix data map for int8 on OmniSciDB #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmnlab
changed the title
xmnlab
force-pushed
the
omniscidb-fix-map-int8
branch
from
60709b6
to
c8dada1
Compare
|
this PR is done for review! thanks! |
|
lgtm. pls rebase |
xmnlab
force-pushed
the
omniscidb-fix-map-int8
branch
from
c8dada1
to
ae21f02
Compare
|
rebase done! thanks @jreback ! |
jreback
approved these changes
Jan 29, 2020
|
thanks @xmnlab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix data map int8 on OmniSciDB