BUG: fix datamgr.py fail if IBIS_TEST_OMNISCIDB_DATABASE=omnisci

[anmyachev]

closes #2049

[xmnlab]

@anmyachev good catch! and thanks for work on that.

maybe you can refactor that a little bit:

• you can remove the else statement you added and
• add a similar code before if (between line 348 and 349)
• and remove database = params["database"] from line 358

eg:

    default_db = 'omnisci'
    database = params["database"]
    
    if params['database'] != default_db:
        conn = pymapd.connect(
            host=params['host'],
            user=params['user'],
            password=params['password'],
            port=params['port'],
            dbname=default_db,
            protocol=params['protocol'],
        )
        stmt = "DROP DATABASE IF EXISTS {}".format(database)
        try:
            conn.execute(stmt)
        except Exception:
            logger.warning('OmniSci DDL statement %r failed', stmt)

        stmt = 'CREATE DATABASE {}'.format(database)
        try:
            conn.execute(stmt)
        except Exception:
            logger.exception('OmniSci DDL statement %r failed', stmt)
        conn.close()

    conn = pymapd.connect(
        host=params['host'],
        user=params['user'],
        password=params['password'],
        port=params['port'],
        dbname=database,
        protocol=params['protocol'],
    )

[anmyachev]

@xmnlab the PR ready for review

[xmnlab]

LGTM! thanks for working on that @anmyachev

[xmnlab]

@anmyachev could you add a release note for that pls? thanks!

[anmyachev]

@xmnlab release note was be added. Thanks for review!

[xmnlab]

Thanks @anmyachev !