-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix CI builds related to new pandas 1.0 compatibility #2061
Conversation
|
thanks for working on that @jrbourbeau ! for the Doc building maybe you can try to change |
|
@jrbourbeau maybe before we move that forward would be good to skip the 2 tests are failing |
|
The |
|
I reran that :) |
|
Thanks @xmnlab. I had set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @jrbourbeau for working on that.
|
@jrbourbeau could you open a follow up issue for these 2 tests you added skip markers ? thanks! |
|
xref #2065 |
|
ah .. just one more thing @jrbourbeau could you add a release note? https://github.com/ibis-project/ibis/blob/master/docs/source/release.rst |
|
thanks @jrbourbeau ! |
|
Thanks for reviewing! |
This PR fixes a couple of issues with the documentation CI build that I noticed over in #2060 which are related to the recent Pandas 1.0 release (see https://dev.azure.com/ibis-project/ibis/_build/results?buildId=1791&view=logs&j=8f09edc2-e3b7-52de-126a-0225c4f3efa1&t=78a72aec-b398-558e-7c0d-2d33604b9e53&l=129)