Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix CI builds related to new pandas 1.0 compatibility #2061

Merged
merged 8 commits into from
Jan 31, 2020

Conversation

jrbourbeau
Copy link
Contributor

This PR fixes a couple of issues with the documentation CI build that I noticed over in #2060 which are related to the recent Pandas 1.0 release (see https://dev.azure.com/ibis-project/ibis/_build/results?buildId=1791&view=logs&j=8f09edc2-e3b7-52de-126a-0225c4f3efa1&t=78a72aec-b398-558e-7c0d-2d33604b9e53&l=129)

@xmnlab
Copy link
Contributor

xmnlab commented Jan 30, 2020

thanks for working on that @jrbourbeau !

for the Doc building maybe you can try to change pd.testing.makeDataFrame() to pd.makeDataFrame()

@jrbourbeau
Copy link
Contributor Author

Thanks for reviewing @xmnlab! The doc build is passing now. I guess we can address the other CI builds in a different PR as part of the larger issue #2063

@xmnlab
Copy link
Contributor

xmnlab commented Jan 31, 2020

@jrbourbeau maybe before we move that forward would be good to skip the 2 tests are failing
but we are still discussing that #2063

@xmnlab xmnlab self-assigned this Jan 31, 2020
@jrbourbeau jrbourbeau changed the title Fix documentation build Fix CI builds Jan 31, 2020
@jrbourbeau
Copy link
Contributor Author

The LinuxBuildConda job is failing, although I'm not sure why. Could I get a restart on that build to see if it consistently fails?

@xmnlab
Copy link
Contributor

xmnlab commented Jan 31, 2020

I reran that :)

@jrbourbeau
Copy link
Contributor Author

Thanks @xmnlab. I had set strict=True on those two added xfails, which was causing test failures on older pandas version where the tests pass. I updated to use strict=False accordingly and CI is passing now

Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @jrbourbeau for working on that.

@xmnlab
Copy link
Contributor

xmnlab commented Jan 31, 2020

@jrbourbeau could you open a follow up issue for these 2 tests you added skip markers ? thanks!

@jrbourbeau jrbourbeau mentioned this pull request Jan 31, 2020
@jrbourbeau
Copy link
Contributor Author

xref #2065

@xmnlab
Copy link
Contributor

xmnlab commented Jan 31, 2020

ah .. just one more thing @jrbourbeau could you add a release note? https://github.com/ibis-project/ibis/blob/master/docs/source/release.rst

@xmnlab xmnlab added bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs labels Jan 31, 2020
@xmnlab xmnlab changed the title Fix CI builds CI: Fix CI builds related to new pandas 1.0 compatibility Jan 31, 2020
@xmnlab xmnlab merged commit fbcbd5d into ibis-project:master Jan 31, 2020
@xmnlab
Copy link
Contributor

xmnlab commented Jan 31, 2020

thanks @jrbourbeau !

@jrbourbeau jrbourbeau deleted the doc-fixup branch January 31, 2020 19:44
@jrbourbeau
Copy link
Contributor Author

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants