Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPP: Disable Postgres Windows CI #2075

Merged
merged 4 commits into from
Feb 10, 2020

Conversation

icexelloss
Copy link
Contributor

No description provided.

@icexelloss icexelloss changed the title SUPP: Disable postgres Windows CI SUPP: Disable Postgres Windows CI Feb 10, 2020
@icexelloss
Copy link
Contributor Author

cc @scottcode Postgres SQL tests are failing on Windows and blocking all merges now. I am attempting to disable it temporarily on Windows to get the CI to green.

I don't have experience debugging postgres SQL, have you done that before maybe shed some light what might be going wrong?

@xmnlab
Copy link
Contributor

xmnlab commented Feb 10, 2020

@icexelloss have you tried with and not postgresql ? maybe you can use and not postgresql and not postgis

@xmnlab
Copy link
Contributor

xmnlab commented Feb 10, 2020

here you can find all the ibis pytest markers https://github.com/ibis-project/ibis/blob/master/setup.cfg#L48

@icexelloss
Copy link
Contributor Author

Thanks let me give that a shot

Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for working on that.

@xmnlab
Copy link
Contributor

xmnlab commented Feb 10, 2020

@icexelloss could you add a release note pls?

@xmnlab xmnlab self-assigned this Feb 10, 2020
@icexelloss
Copy link
Contributor Author

Sure, give me a sec

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note release notes are not needed for CI things

can u open an issue to re enable this when fixed

@jreback jreback added this to the Next Feature Release milestone Feb 10, 2020
@icexelloss
Copy link
Contributor Author

Created issue #2076

@xmnlab
Copy link
Contributor

xmnlab commented Feb 10, 2020

@jreback as the previous workflow didn't request a release note, it was been generated automatically by a script, for all types of PR (support, bug, feature), so documentation for contributing doesn't specify details about when add or don't add a release note (https://docs.ibis-project.org/contributing.html#commit-pr-messages).

could you provide a text about that?

@xmnlab xmnlab merged commit fb3b399 into ibis-project:master Feb 10, 2020
@jreback
Copy link
Contributor

jreback commented Feb 10, 2020

@xmnlab release notes are meant for end users
excluding
things that are CI relegated is common

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants