-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUPP: Disable Postgres Windows CI #2075
SUPP: Disable Postgres Windows CI #2075
Conversation
|
cc @scottcode Postgres SQL tests are failing on Windows and blocking all merges now. I am attempting to disable it temporarily on Windows to get the CI to green. I don't have experience debugging postgres SQL, have you done that before maybe shed some light what might be going wrong? |
|
@icexelloss have you tried with |
|
here you can find all the ibis pytest markers https://github.com/ibis-project/ibis/blob/master/setup.cfg#L48 |
|
Thanks let me give that a shot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for working on that.
|
@icexelloss could you add a release note pls? |
|
Sure, give me a sec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note release notes are not needed for CI things
can u open an issue to re enable this when fixed
|
Created issue #2076 |
|
@jreback as the previous workflow didn't request a release note, it was been generated automatically by a script, for all types of PR (support, bug, feature), so documentation for contributing doesn't specify details about when add or don't add a release note (https://docs.ibis-project.org/contributing.html#commit-pr-messages). could you provide a text about that? |
|
@xmnlab release notes are meant for end users |
No description provided.