Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Change OmniSciDB docker image version from v5.0.0 to v5.1.0 #2077

Merged
merged 4 commits into from
Feb 17, 2020
Merged

CI: Change OmniSciDB docker image version from v5.0.0 to v5.1.0 #2077

merged 4 commits into from
Feb 17, 2020

Conversation

anmyachev
Copy link
Contributor

No description provided.

@anmyachev
Copy link
Contributor Author

the PR's CI should be green after merging #2051

@jreback
Copy link
Contributor

jreback commented Feb 13, 2020

is there any expectation of backwards compatibility? can you update the docs

@anmyachev
Copy link
Contributor Author

is there any expectation of backwards compatibility? can you update the docs

I just know that the new release changes the behavior of geo functions (due to SRID). Where better to mention this?

@semelianova semelianova mentioned this pull request Feb 17, 2020
Closed
@xmnlab xmnlab self-assigned this Feb 17, 2020
@xmnlab xmnlab added the ci Continuous Integration issues or PRs label Feb 17, 2020
@xmnlab xmnlab changed the title change omnisci version: v5.0.0 -> v5.1.0 CI: Change OmniSciDB docker image version from v5.0.0 to v5.1.0 Feb 17, 2020
xmnlab
xmnlab approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @anmyachev for working on that!

@xmnlab xmnlab merged commit ef6a4ed into ibis-project:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab xmnlab approved these changes

Assignees

@xmnlab xmnlab

Labels
ci Continuous Integration issues or PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anmyachev @jreback @xmnlab