-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: change clickhouse-driver version to >=0.1.3 #2089
Conversation
|
@anmyachev just a question, in the issue the error message says: |
|
@anmyachev you also will need to change https://github.com/ibis-project/ibis/blob/master/setup.py#L29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update setup.py as well. pls add a note to the whatsnew and under the clickhouse section in the docs on min requirements
I found #2005 which says about incompatibility with version 0.1.2 |
I didn't find clickhouse section place for version update :( |
|
@jreback the |
https://docs.ibis-project.org/getting-started.html?highlight=clickhouse#clickhouse-quickstart add a versionadded tag (1.3), saying that the required versions of clickhouse have now increased to .... |
|
great ping on green |
|
@jreback ping on green |
|
thanks @anmyachev |
closes #2088