Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: change clickhouse-driver version to >=0.1.3 #2089

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

anmyachev
Copy link
Contributor

closes #2088

@xmnlab
Copy link
Contributor

xmnlab commented Feb 24, 2020

@anmyachev just a question, in the issue the error message says: Requirement.parse('clickhouse-driver>=0.1.2') ... is there any reason you pinned >=0.1.3?

@xmnlab
Copy link
Contributor

xmnlab commented Feb 24, 2020

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update setup.py as well. pls add a note to the whatsnew and under the clickhouse section in the docs on min requirements

@jreback jreback added this to the Next Feature Release milestone Feb 24, 2020
@jreback jreback added the clickhouse The ClickHouse backend label Feb 24, 2020
@anmyachev
Copy link
Contributor Author

@anmyachev just a question, in the issue the error message says: Requirement.parse('clickhouse-driver>=0.1.2') ... is there any reason you pinned >=0.1.3?

I found #2005 which says about incompatibility with version 0.1.2

@anmyachev
Copy link
Contributor Author

update setup.py as well. pls add a note to the whatsnew and under the clickhouse section in the docs on min requirements

I didn't find clickhouse section place for version update :(

@anmyachev
Copy link
Contributor Author

@jreback the clickhouse-driver version is service information that the ordinary user does not need, unlike the server version(yandex/clickhouse-server:18.12). I did not add mention of the driver's changed version, but I think the PR ready for review :)

@jreback
Copy link
Contributor

jreback commented Feb 26, 2020

update setup.py as well. pls add a note to the whatsnew and under the clickhouse section in the docs on min requirements

I didn't find clickhouse section place for version update :(

https://docs.ibis-project.org/getting-started.html?highlight=clickhouse#clickhouse-quickstart

add a versionadded tag (1.3), saying that the required versions of clickhouse have now increased to ....

@jreback
Copy link
Contributor

jreback commented Feb 26, 2020

great ping on green

@anmyachev
Copy link
Contributor Author

@jreback ping on green

@jreback jreback merged commit 5b47e0b into ibis-project:master Feb 26, 2020
@jreback
Copy link
Contributor

jreback commented Feb 26, 2020

thanks @anmyachev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clickhouse The ClickHouse backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: load test datasets CI step failed
3 participants