FEAT: OmniSciDB Log Log2 Log10 implementations #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
these PRa are good |
jreback
suggested changes
Feb 26, 2020
ci/docker-compose.yml
Outdated
| @@ -89,7 +89,7 @@ services: | |||
| KUDU_MASTER: "false" | |||
|
|
|||
| omniscidb: | |||
| image: omnisci/core-os-cpu:v5.1.0 | |||
| image: omnisci/core-os-cpu-dev:latest | |||
There was a problem hiding this comment.
@xmnlab is this right? why are we not pinning exactly (to 5.2?)
There was a problem hiding this comment.
My several pull requests aren't working with the latest omnisci release due to a lack of some changes.
|
pls merge master |
|
can you merge master, update the release.rst, and remove the change in the image. |
|
Need to wait for #2084 is merged |
jreback
reviewed
Mar 24, 2020
| @@ -1037,6 +1075,7 @@ def formatter(translator, expr): | |||
| ops.Greatest, | |||
| ops.Log2, | |||
| ops.Log, | |||
| ops.Round, | |||
There was a problem hiding this comment.
was this just missing before?
jreback
approved these changes
Mar 27, 2020
|
thanks @semelianova |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.