Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: OmniSciDB ops.Date, ops.DateDiff and ops.TimestampDiff implementation #2097

Merged
merged 8 commits into from
Mar 20, 2020
Merged

FEAT: OmniSciDB ops.Date, ops.DateDiff and ops.TimestampDiff implementation #2097

merged 8 commits into from
Mar 20, 2020

Conversation

semelianova
Copy link
Contributor

No description provided.

@semelianova semelianova changed the title FEAT: OmniSciDB ops.Date implementation FEAT: OmniSciDB ops.Date and ops.DateDiff implementation Feb 26, 2020
@semelianova semelianova changed the title FEAT: OmniSciDB ops.Date and ops.DateDiff implementation FEAT: OmniSciDB ops.Date, ops.DateDiff and ops.TimestampDiff implementation Feb 26, 2020
@semelianova
Copy link
Contributor Author

@xmnlab @jreback PR is ready for review

xmnlab
xmnlab reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@semelianova LGTM! thanks for working on that!

as I commented in another PR, you don't need to add "_workaround" to the function name.

could you add a release note for your change pls? thanks!

@jreback when you have time could you give a second review pls? thanks!

@xmnlab xmnlab added feature Features or general enhancements omnisci labels Mar 6, 2020
jreback
jreback suggested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are these tested?

@semelianova
Copy link
Contributor Author

ops.DateDiff is tested in test_timestamp_truncate and test_date_truncate
ops.Date and ops.TimestampDiff are tested in test_temporal_binop

@jreback jreback added this to the Next Feature Release milestone Mar 14, 2020
@jreback jreback merged commit 9103b91 into ibis-project:master Mar 20, 2020
@jreback
Copy link
Contributor

jreback commented Mar 20, 2020

thanks @semelianova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab xmnlab left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
feature Features or general enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@semelianova @jreback @xmnlab