FEAT: OmniSciDB Added fragment_size to table creation #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semelianova
force-pushed
the
gragment_size
branch
from
86732c1
to
d8a6b4b
Compare
xmnlab
added
ddl
semelianova
force-pushed
the
gragment_size
branch
from
4de36eb
to
0ed3941
Compare
jreback
suggested changes
Mar 12, 2020
semelianova
force-pushed
the
gragment_size
branch
from
0ed3941
to
b22ce53
Compare
|
Hello @semelianova! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-17 02:06:16 UTC |
jreback
suggested changes
Mar 14, 2020
|
can you rebase |
semelianova
force-pushed
the
gragment_size
branch
from
aab10b8
to
f599820
Compare
What do you mean? Comment to pr or something else? |
meaning when the CI is green (as now), pls make a comment |
jreback
approved these changes
Mar 18, 2020
|
thanks @semelianova |
xmnlab
reviewed
Mar 20, 2020
| @@ -10,6 +10,7 @@ Release Notes | |||
| * :feature:`2126` Add translation rules for isnull() and notnull() for pyspark backend | |||
| * :feature:`2062` Implement read_csv for omniscidb backend | |||
| * :feature:`2060` Add initial support for ibis.random function | |||
| * :support:`2107` Added fragment_size to table creation for OmniSciDB | |||
There was a problem hiding this comment.
I am wondering if it should be feature instead of support ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.